Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): add missing chalk and lodash dependencies #3192

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

ylemkimon
Copy link
Contributor

@ylemkimon ylemkimon commented Aug 3, 2020

Motivation

Dependencies to chalk and lodash were added in f4434b2#diff-cccb3a8017ec51e8bfa9eb7c8c6934b3 and 9fab79c, respectively, but wasn't added to package.json.

This causes errors in Yarn 2:

[MODULE_NOT_FOUND] Error: @docusaurus/plugin-content-docs tried to access chalk, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.
[MODULE_NOT_FOUND] Error: @docusaurus/plugin-content-docs tried to access lodash, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

In the "Start test-website project" step of Yarn 2 E2E test, verify following errors are not printed:

[MODULE_NOT_FOUND] Error: @docusaurus/plugin-content-docs tried to access chalk, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.
[MODULE_NOT_FOUND] Error: @docusaurus/plugin-content-docs tried to access lodash, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Related PRs

Related issue: #3003

@ylemkimon ylemkimon requested a review from yangshun as a code owner August 3, 2020 07:20
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 3, 2020
@ylemkimon ylemkimon changed the title fix(v2): add missing dependencies to chalk and lodash fix(v2): add missing chalk and lodash dependencies Aug 3, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 36d3649

https://deploy-preview-3192--docusaurus-2.netlify.app

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Aug 3, 2020
@slorber slorber merged commit 9663173 into facebook:master Aug 3, 2020
@slorber
Copy link
Collaborator

slorber commented Aug 3, 2020

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants